fix helper logic

plotly · cpsievert · Jun 8, 2021 · Jun 8, 2021 · Jun 8, 2021 · Jun 9, 2021
commit e7dee15436b6dab359d89a4f15b5f75472b3d5fa
diff --git a/tests/testthat/helper-skip.R b/tests/testthat/helper-skip.R
@@ -19,7 +19,7 @@ skip_cloud_tests <- function() {
 skip_shinytest_tests <- function() {
  skip_on_cran()
  skip_if_not_installed("shinytest")
-  if (!as.logical(Sys.getenv("SHINYTEST", FALSE))) {
+  if (grepl("true", Sys.getenv("SHINYTEST"), fixed = TRUE)) {
    skip("shinytest testing requires the SHINYTEST environment variable to be true")
  }
 }
diff --git a/tests/testthat/helper-vdiffr.R b/tests/testthat/helper-vdiffr.R
@@ -1,5 +1,5 @@
 # If VDIFFR is TRUE, enable visual testing
-enable_vdiffr <- as.logical(Sys.getenv("VDIFFR", FALSE))
+enable_vdiffr <- grepl("true", Sys.getenv("VDIFFR"), fixed = TRUE)

 message("Visual testing is ", if (!enable_vdiffr) "not ", "enabled.")