Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

proposed change to avoid peeking at 'grid' unit internals #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2019
Merged

proposed change to avoid peeking at 'grid' unit internals #1646

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c889fa2
proposed change to avoid peeking at 'grid' unit internals
pmur002 Oct 22, 2019
c708f76
improve previous commit
pmur002 Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
improve previous commit
  • Loading branch information
@pmur002
pmur002 committed Oct 23, 2019
commit c708f76e2c0f89374147443eb4825c5ed69eece9
3 changes: 2 additions & 1 deletion 3 R/ggplotly.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1138,7 +1138,8 @@ unitConvert <- function(u, to = c("npc", "pixels"), type = c("x", "y", "height",
mm2pixels <- function(u) {
u <- verifyUnit(u)
if (getRversion() >= "4.0.0") {
if (grid::unitType(u) != "mm") {
unitType <- get("unitType", envir=asNamespace("grid"))
if (unitType(u) != "mm") {
stop("Unit must be in millimeters")
}
} else {
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.