ggplotly(): fix Xaxis anchor if the last row incomplete #1501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attach X axis to the last non-empty row in a column
cpsievert
reviewed
Apr 3, 2019
| layout$layout <- dplyr::group_by(layout$layout, xaxis) %>% | ||
| dplyr::mutate(xanchor = max(as.integer(yaxis))) %>% | ||
| dplyr::ungroup() %>% | ||
| dplyr::mutate(xanchor = if (is.factor(yaxis)) levels(yaxis)[xanchor] else xanchor) | ||
| } |
There was a problem hiding this comment.
I don't immediately follow why dplyr::mutate(xanchor = if (is.factor(yaxis)) levels(yaxis)[xanchor] else xanchor) is necessary, do you have an example in mind where this becomes relevant?
There was a problem hiding this comment.
Yes, it looks a bit ugly. I had trouble with some of the plots (maybe even the ones in the tests) when either a PANEL or COL is a factor.
There was some error happening afterwards, but unfortunately I forgot the details. So I had to convert xanchor back to a factor.
|
Thanks @alyst, again looking great! It'd be really awesome if you could either point out an existing test or add another test for the code I mentioned in https://github.com/ropensci/plotly/pull/1501/files#r271834045 |
and if we do, it likely needs a different fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continuation of the closed PR #619 after rebasing the changes to the current master.
ggplotly handles the
facet_wrap()with the incomplete last row differently from ggplot2:ggplot()attaches the X axis to the last plot in the column, whereasggplotly(ggplot())always puts it to the last row, even when there are no plots at that position. IMHO the ggplot2 behaviour is better -- there are no "floating" axes; the axes are always attached to the plots.There's one testcase affected by the fix: "facet_wrap-free_y-2" (it also demonstrates the difference between ggplot and current ggplotly behaviours).
I guess I also need to fix the reference .png image, but I'm not sure how to properly do it.