start the CLI in production mode #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Member
Author
|
cc @rozilla |
There was a problem hiding this comment.
Pull Request Overview
This PR aims to start the CLI in production mode by adjusting runtime environment settings and streamlining runtime selection behavior.
- Added a debug log for NODE_ENV and modified runtime selection logic in the API route
- Updated the startup script to set a production port and adjust configuration loading
- Tweaked CLI output to display production startup messages
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| web/backend/routes/root.ts | Added logging of NODE_ENV and adjusted runtime selection logic |
| lib/start.js | Removed use of SELECTED_RUNTIME and set a fixed port |
| cli.js | Removed redundant output and added production startup messages |
Comments suppressed due to low confidence (1)
lib/start.js:6
- The removed assignment to process.env.SELECTED_RUNTIME may break the runtime selection logic in the API route; ensure that the selectedRuntime value is properly propagated if needed.
process.env.SELECTED_RUNTIME = selectedRuntime
web/backend/routes/root.ts
Outdated
| const typedFastify = fastify.withTypeProvider<JsonSchemaToTsProvider>() | ||
| const api = new RuntimeApiClient() | ||
|
|
||
| console.log(process.env.NODE_ENV) |
There was a problem hiding this comment.
Remove or replace the console.log with a proper logging mechanism to avoid exposing internal environment details in production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.