fix: handle null JSON output in worker logs #4488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a worker outputs the literal string "null" to stdout, JSON.parse returns null. Since typeof null === 'object' in JavaScript, the code would enter the object branch and crash trying to access null.level. This adds a null check to prevent the crash. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com> Signed-off-by: Matteo Collina <hello@matteocollina.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nullto stdout/stderrJSON.parse("null")returnsnull, and sincetypeof null === 'object'(JavaScript quirk), the code would enter the object branch and crash trying to accessnull.levelTest plan
should handle literal null output from workers without crashing🤖 Generated with Claude Code