Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@marcopiraccini
Copy link
Contributor

in #4084 We accidentally removed:

collect: function () {

(and we didn't have a test to catch it).
Fixed back and added the tests.

Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
@marcopiraccini marcopiraccini marked this pull request as ready for review June 18, 2025 09:38
@marcopiraccini marcopiraccini changed the title regression fix: we need to reset when we collect latencies Regression fix: Reset when we collect latencies Jun 18, 2025
Copy link
Contributor

@leorossi leorossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Ship it.

@marcopiraccini marcopiraccini merged commit 82cb6bf into main Jun 18, 2025
642 of 648 checks passed
@marcopiraccini marcopiraccini deleted the reset-on-collect-latencies branch June 18, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.