[storage] Add temporary url functionality to openstack storage #493
Conversation
|
I've rebased my branch to latest upstream master. |
|
Can I get any comment on this regarding whether it might get merged in or if it needs additional work? |
|
@rosskukulinski @vivekzhere @jcrugzz or any maintainer at all. This PR has been open for more than a year without any comment. The functionality implemented here already exists for rackspace storage with nearly the same code so I can't fathom why this wouldn't be acceptable save for some flaw in my code. My team is still using this version in our application but would prefer to be using pkgcloud proper. If this project is no longer maintained then please say so so that your users can begin migrating to another solution. |
|
Any update on this PR ? I'd be happy to use it as part of pkgcloud ! |
|
Thanks @phairoh |
This pull requests adds temporary url functionality to openstack storage. It is modeled off of the code written specifically for the rackspace provider as well as the similar implementation from pyrax.
With this update, you can both set and get the temporary url key associated with your account in addition to generating the temporary url itself.
Because the rackspace storage provider uses the openstack provider's storageClient object, it was necessary to add the additional file file
account.jsalong with the corresponding extend inclient/index.js.There were no previous tests written for openstack storage so I have created a few simple ones for this new functionality. Due to my unfamiliarity with
hockthey may be more verbose than is needed but they do seem to model the functionality as expected. Note:npm testcurrently fails (as seen in the failed travis builds) due to some issue with blanket. After removing theblanketintegration, tests run but there are 14 failing, none of which dealt with openstack storage. Both of these concerns were outside of the scope of this pull request so I did not investigate them too deeply. The newly added tests all complete successfully.This pull request should close #422 and and possibly #376