Fix HeaderBag::all return value #282
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
approved these changes
Jun 7, 2022
ondrejmirtes
requested changes
Jun 7, 2022
There was a problem hiding this comment.
- I'd say there are more
*Bagclasses with the same behaviour, can you please update stubs for all of them? - I'd say we should be able to remove this extension altogether with the help of conditional return types: https://github.com/phpstan/phpstan-symfony/blob/1.2.x/src/Type/Symfony/InputBagDynamicReturnTypeExtension.php
|
Yeah, if someone else has time to take this over to do a more comprehensive fix please feel free. I don't know when I'll get to it otherwise. This isn't very high on my list. |
|
For the record, the conditional type was accepted in Symfony 6.3, cf symfony/symfony#49007 |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #264