Fix keyword parsing#590
Merged
MauricioFauth merged 2 commits intophpmyadmin:5.10.xphpmyadmin/sql-parser:5.10.xfrom Oct 25, 2024
kamil-tekiela:Fix-keyword-parsingkamil-tekiela/sql-parser:Fix-keyword-parsingCopy head branch name to clipboard
Merged
Fix keyword parsing#590MauricioFauth merged 2 commits intophpmyadmin:5.10.xphpmyadmin/sql-parser:5.10.xfrom kamil-tekiela:Fix-keyword-parsingkamil-tekiela/sql-parser:Fix-keyword-parsingCopy head branch name to clipboard
MauricioFauth merged 2 commits intophpmyadmin:5.10.xphpmyadmin/sql-parser:5.10.xfrom
kamil-tekiela:Fix-keyword-parsingkamil-tekiela/sql-parser:Fix-keyword-parsingCopy head branch name to clipboard
Conversation
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
williamdes
approved these changes
Oct 20, 2024
Member
williamdes
left a comment
There was a problem hiding this comment.
This looks okay, thank you
MauricioFauth
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure if this is the right base and I don't know what the psalm and phpstan changes are about.
This should fix phpmyadmin/phpmyadmin#19320