Drop Utils\Routine class#585
Merged
MauricioFauth merged 1 commit intophpmyadmin:masterphpmyadmin/sql-parser:masterfrom Sep 24, 2024
Merged
Drop Utils\Routine class#585MauricioFauth merged 1 commit intophpmyadmin:masterphpmyadmin/sql-parser:masterfrom
MauricioFauth merged 1 commit intophpmyadmin:masterphpmyadmin/sql-parser:masterfrom
Conversation
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
ea51fe4 to
d8cede5
Compare
MauricioFauth
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only 1 of 3 methods is used in PMA and it really belongs in
Routinesclass in PMA and not here. All three methods return unfriendly array shapes and do not look very useful.