Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Feature/from 5 9 define context keywords relying on token constants#570

Merged
MauricioFauth merged 11 commits intophpmyadmin:5.10.xphpmyadmin/sql-parser:5.10.xfrom
niconoe-:feature/from-5-9-define-context-keywords-relying-on-token-constantsniconoe-/sql-parser:feature/from-5-9-define-context-keywords-relying-on-token-constantsCopy head branch name to clipboard
Aug 25, 2024
Merged

Feature/from 5 9 define context keywords relying on token constants#570
MauricioFauth merged 11 commits intophpmyadmin:5.10.xphpmyadmin/sql-parser:5.10.xfrom
niconoe-:feature/from-5-9-define-context-keywords-relying-on-token-constantsniconoe-/sql-parser:feature/from-5-9-define-context-keywords-relying-on-token-constantsCopy head branch name to clipboard

Conversation

@niconoe-
Copy link
Contributor

@niconoe- niconoe- commented Aug 6, 2024

Same as #569 but from 5.9.x branch.

@niconoe-
Copy link
Contributor Author

niconoe- commented Aug 6, 2024

@williamdes / @kamil-tekiela
Are you OK with these changes? I'm having issues with PHPStan about files I didn't change, and with Psalm on Generated contextes but this will be fixed on future versions (with PHP 8.2 minimum) I guess.
Benchmark issues, I don't get it too…

phpstan-baseline.neon Outdated Show resolved Hide resolved
src/Tools/ContextGenerator.php Outdated Show resolved Hide resolved
src/Tools/ContextGenerator.php Outdated Show resolved Hide resolved
src/Tools/ContextGenerator.php Show resolved Hide resolved
src/Tools/ContextGenerator.php Outdated Show resolved Hide resolved
@niconoe-
Copy link
Contributor Author

@williamdes (and maybe @MauricioFauth ) any chance to see this integrated soon? Or do you need something from me before? Thanks 🙂

@williamdes
Copy link
Member

@williamdes (and maybe @MauricioFauth ) any chance to see this integrated soon? Or do you need something from me before? Thanks 🙂

For me this is all good, only awaiting a review from @MauricioFauth

@MauricioFauth MauricioFauth changed the base branch from 5.9.x to 5.10.x August 25, 2024 16:23
@MauricioFauth MauricioFauth merged commit 9fa8ca9 into phpmyadmin:5.10.x Aug 25, 2024
@MauricioFauth MauricioFauth self-assigned this Aug 25, 2024
@MauricioFauth MauricioFauth added this to the 5.10.0 milestone Aug 25, 2024
@niconoe- niconoe- deleted the feature/from-5-9-define-context-keywords-relying-on-token-constants branch August 26, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.