Define context keywords relying on Token constants#568
Closed
Tithugues wants to merge 1 commit intophpmyadmin:masterphpmyadmin/sql-parser:masterfrom
Tithugues:feature/define-context-keywords-relying-on-token-constantsTithugues/sql-parser:feature/define-context-keywords-relying-on-token-constantsCopy head branch name to clipboard
Closed
Define context keywords relying on Token constants#568Tithugues wants to merge 1 commit intophpmyadmin:masterphpmyadmin/sql-parser:masterfrom Tithugues:feature/define-context-keywords-relying-on-token-constantsTithugues/sql-parser:feature/define-context-keywords-relying-on-token-constantsCopy head branch name to clipboard
Tithugues wants to merge 1 commit intophpmyadmin:masterphpmyadmin/sql-parser:masterfrom
Tithugues:feature/define-context-keywords-relying-on-token-constantsTithugues/sql-parser:feature/define-context-keywords-relying-on-token-constantsCopy head branch name to clipboard
Conversation
|
These files are autogenerated with https://github.com/phpmyadmin/sql-parser/blob/master/tools/run_generators.sh This is the code that prints the keywords: sql-parser/src/Tools/ContextGenerator.php Lines 234 to 247 in 3bc8d0d |
Contributor
Author
|
OK, thanks. Then I’ll take a look at the generator. 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I always had issues to understand the "magic" keyword integers of the Context* files. Would it make sense to rely on Token constants to define them?
Additionally, I added a variable for the default bit needed for all keywords.