Fix where 0#560
Merged
MauricioFauth merged 2 commits intophpmyadmin:5.10.xphpmyadmin/sql-parser:5.10.xfrom Jun 1, 2024
Merged
Conversation
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
kamil-tekiela
approved these changes
May 31, 2024
Contributor
kamil-tekiela
left a comment
There was a problem hiding this comment.
Perfect! There is no way for this variable to be anything other than a string at this point.
MauricioFauth
approved these changes
Jun 1, 2024
MauricioFauth
added a commit
to phpmyadmin/phpmyadmin
that referenced
this pull request
Jun 16, 2024
Fixes #19187 Depends on phpmyadmin/sql-parser#560 to work without regression in the case of a condition `0` because now the query is parsed and built again to remove comments. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a part of a condition is
0it was not parsed correctly