Allow parsing ALTER TABLE statement with column check constraint#554
Merged
MauricioFauth merged 1 commit intophpmyadmin:5.9.xphpmyadmin/sql-parser:5.9.xfrom May 23, 2024
MoonE:support-alter-table-with-column-check-constraintMoonE/sql-parser:support-alter-table-with-column-check-constraintCopy head branch name to clipboard
Merged
Allow parsing ALTER TABLE statement with column check constraint#554MauricioFauth merged 1 commit intophpmyadmin:5.9.xphpmyadmin/sql-parser:5.9.xfrom MoonE:support-alter-table-with-column-check-constraintMoonE/sql-parser:support-alter-table-with-column-check-constraintCopy head branch name to clipboard
MauricioFauth merged 1 commit intophpmyadmin:5.9.xphpmyadmin/sql-parser:5.9.xfrom
MoonE:support-alter-table-with-column-check-constraintMoonE/sql-parser:support-alter-table-with-column-check-constraintCopy head branch name to clipboard
Conversation
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
williamdes
approved these changes
May 9, 2024
williamdes
reviewed
May 9, 2024
MauricioFauth
approved these changes
May 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHECKis in Parser::STATEMENT_PARSERS, but also allowed in the column definition.This doesn't enforce an order for the check constraint. It seems to be only allowed at the end of the column definition, only the column order (
FIRST/AFTER x) can follow.