Fix using ? as a parameter#515
Merged
MauricioFauth merged 1 commit intophpmyadmin:5.9.xphpmyadmin/sql-parser:5.9.xfrom Sep 26, 2023
MauricioFauth:question-mark-paramMauricioFauth/sql-parser:question-mark-paramCopy head branch name to clipboard
Merged
Fix using ? as a parameter#515MauricioFauth merged 1 commit intophpmyadmin:5.9.xphpmyadmin/sql-parser:5.9.xfrom MauricioFauth:question-mark-paramMauricioFauth/sql-parser:question-mark-paramCopy head branch name to clipboard
MauricioFauth merged 1 commit intophpmyadmin:5.9.xphpmyadmin/sql-parser:5.9.xfrom
MauricioFauth:question-mark-paramMauricioFauth/sql-parser:question-mark-paramCopy head branch name to clipboard
Conversation
Member
MauricioFauth
commented
Sep 26, 2023
- Fixes doesn't support sql parameter in set clause #202
- Fixes Support for parameterized select clauses #412
- Fixes Missing support for SET = ? #492
- Closes Add support for set = ? for parser #499
- Related to Support named parameters #172
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.9.x #515 +/- ##
=========================================
Coverage 97.03% 97.03%
- Complexity 2240 2243 +3
=========================================
Files 69 69
Lines 5153 5154 +1
=========================================
+ Hits 5000 5001 +1
Misses 153 153
☔ View full report in Codecov by Sentry. |
williamdes
reviewed
Sep 26, 2023
- Fixes phpmyadmin#202 - Fixes phpmyadmin#412 - Fixes phpmyadmin#492 - Closes phpmyadmin#499 - Related to phpmyadmin#172 Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
74504c5 to
170dbe5
Compare
williamdes
reviewed
Sep 26, 2023
williamdes
approved these changes
Sep 26, 2023
Member
williamdes
left a comment
There was a problem hiding this comment.
Awesome !
Will it be easy to detect the ? or := for our (broken) feature "Bind parameters" in the query box ?
Member
Author
Is there an issue for that? |
Member
No, I did not report it until now since the parser has unhappy |
MauricioFauth
added a commit
that referenced
this pull request
Jan 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.