Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Make constants const#505

Merged
MauricioFauth merged 2 commits intophpmyadmin:masterphpmyadmin/sql-parser:masterfrom
kamil-tekiela:Make-constants-constkamil-tekiela/sql-parser:Make-constants-constCopy head branch name to clipboard
Sep 17, 2023
Merged

Make constants const#505
MauricioFauth merged 2 commits intophpmyadmin:masterphpmyadmin/sql-parser:masterfrom
kamil-tekiela:Make-constants-constkamil-tekiela/sql-parser:Make-constants-constCopy head branch name to clipboard

Conversation

@kamil-tekiela
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3f50a4d) 96.45% compared to head (c3dca8b) 96.46%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #505   +/-   ##
=========================================
  Coverage     96.45%   96.46%           
  Complexity     2172     2172           
=========================================
  Files            66       66           
  Lines          5050     5062   +12     
=========================================
+ Hits           4871     4883   +12     
  Misses          179      179           
Files Changed Coverage Δ
src/Statements/MaintenanceStatement.php 100.00% <ø> (ø)
src/Statements/SelectStatement.php 100.00% <ø> (ø)
src/Statements/SetStatement.php 100.00% <ø> (ø)
src/Tools/CustomJsonSerializer.php 0.00% <ø> (ø)
src/Components/AlterOperation.php 98.67% <100.00%> (ø)
src/Components/Condition.php 100.00% <100.00%> (ø)
src/Components/CreateDefinition.php 100.00% <100.00%> (ø)
src/Components/DataType.php 100.00% <100.00%> (ø)
src/Components/Expression.php 100.00% <100.00%> (ø)
src/Components/IntoKeyword.php 100.00% <100.00%> (ø)
... and 11 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kamil-tekiela kamil-tekiela marked this pull request as draft September 6, 2023 16:22
@kamil-tekiela kamil-tekiela force-pushed the Make-constants-const branch 2 times, most recently from a269969 to 79e2d3c Compare September 6, 2023 23:37
@kamil-tekiela kamil-tekiela marked this pull request as ready for review September 6, 2023 23:44
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consts are still overridable, right ? (by inheritance)

@kamil-tekiela
Copy link
Contributor Author

consts are still overridable, right ? (by inheritance)

Yes, I didn't add final flag to any of them. But overriding constants don't play well with phpcs so I skip the remaining overridden properties which should be overridden constants now.

@MauricioFauth MauricioFauth added this to the 6.0.0 milestone Sep 16, 2023
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
@MauricioFauth MauricioFauth merged commit 6b20105 into phpmyadmin:master Sep 17, 2023
@MauricioFauth MauricioFauth self-assigned this Sep 17, 2023
@kamil-tekiela kamil-tekiela deleted the Make-constants-const branch September 17, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.