Restrict param type of OptionsArray::merge#470
Merged
williamdes merged 2 commits intophpmyadmin:masterphpmyadmin/sql-parser:masterfrom Jun 29, 2023
kamil-tekiela:OptionsArray-mergekamil-tekiela/sql-parser:OptionsArray-mergeCopy head branch name to clipboard
Merged
Restrict param type of OptionsArray::merge#470williamdes merged 2 commits intophpmyadmin:masterphpmyadmin/sql-parser:masterfrom kamil-tekiela:OptionsArray-mergekamil-tekiela/sql-parser:OptionsArray-mergeCopy head branch name to clipboard
williamdes merged 2 commits intophpmyadmin:masterphpmyadmin/sql-parser:masterfrom
kamil-tekiela:OptionsArray-mergekamil-tekiela/sql-parser:OptionsArray-mergeCopy head branch name to clipboard
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #470 +/- ##
============================================
- Coverage 96.61% 96.61% -0.01%
+ Complexity 2181 2178 -3
============================================
Files 66 66
Lines 5059 5056 -3
============================================
- Hits 4888 4885 -3
Misses 171 171
☔ View full report in Codecov by Sentry. |
056bf0b to
240d3fb
Compare
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
240d3fb to
5293688
Compare
williamdes
approved these changes
Jun 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have no need to allow this method to take an array. Even upstream PMA doesn't use this method.