Change Component abstract class to an interface#365
Merged
MauricioFauth merged 1 commit intophpmyadmin:6.0.xphpmyadmin/sql-parser:6.0.xfrom Jan 3, 2022
MauricioFauth:component-interfaceMauricioFauth/sql-parser:component-interfaceCopy head branch name to clipboard
Merged
Change Component abstract class to an interface#365MauricioFauth merged 1 commit intophpmyadmin:6.0.xphpmyadmin/sql-parser:6.0.xfrom MauricioFauth:component-interfaceMauricioFauth/sql-parser:component-interfaceCopy head branch name to clipboard
Component abstract class to an interface#365MauricioFauth merged 1 commit intophpmyadmin:6.0.xphpmyadmin/sql-parser:6.0.xfrom
MauricioFauth:component-interfaceMauricioFauth/sql-parser:component-interfaceCopy head branch name to clipboard
Conversation
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
williamdes
approved these changes
Jan 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PhpMyAdmin\SqlParser\Componentabstract class has only two methods that are not implemented serving only as a contract. Changing it to an interface makes more sense.