Add GroupKeyword class to fix postgres GROUP BY#155
Closed
JoseNetoooo wants to merge 3 commits intophpmyadmin:masterphpmyadmin/sql-parser:masterfrom
Closed
Add GroupKeyword class to fix postgres GROUP BY#155JoseNetoooo wants to merge 3 commits intophpmyadmin:masterphpmyadmin/sql-parser:masterfrom
JoseNetoooo wants to merge 3 commits intophpmyadmin:masterphpmyadmin/sql-parser:masterfrom
Conversation
nijel
added a commit
that referenced
this pull request
Jun 1, 2017
Signed-off-by: Michal Čihař <michal@cihar.com>
Contributor
|
Thanks, I've merged the functional changes. Quite obviously the composer changes are not for merge... |
Contributor
Author
|
Ok, Thanks! ...and sorry for the composer changes in that pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As related here https://github.com/phpmyadmin/sql-parser/issues/154 by me, PostgresSQL does not accept ASC or DESC after the GROUP BY keyword. My purpose is to create a new class called GroupKeyword with an empty default type. Why to create a new class? I think because maybe we need to be more specific in some scenarios.
Anyway, thank you so much for this Sql Parser.