Fix for Bug#4237 #896
Closed
JayNakrani wants to merge 3 commits intophpmyadmin:masterphpmyadmin/phpmyadmin:masterfrom
JayNakrani:bugs#4237Copy head branch name to clipboard
Closed
Fix for Bug#4237 #896JayNakrani wants to merge 3 commits intophpmyadmin:masterphpmyadmin/phpmyadmin:masterfrom JayNakrani:bugs#4237Copy head branch name to clipboard
JayNakrani wants to merge 3 commits intophpmyadmin:masterphpmyadmin/phpmyadmin:masterfrom
JayNakrani:bugs#4237Copy head branch name to clipboard
Conversation
Signed-off-by: Dhananjay <dhananjaynakrani@gmail.com>
Contributor
Author
|
I am changing the data in failed Tests. Will be pushing those changes very soon. |
Signed-off-by: Dhananjay <dhananjaynakrani@gmail.com>
Contributor
Author
|
Now with previous changes Travis-CI build passes, see here. I'll create a new pull where I'll squash commits and reorder them properly and also include Signed-off tag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In continuation with Pull Request#893...
Whitelist check for domains in url.php has been added. I've tried to add as many valid domains into the Whitelist as I could. Please point out if any domains have been missed.
Travis-CI build fails because, it is comparing the new results with some old result which has token in all its outgoing URLs, and so string comparisons fails on those URLs. See build log.