Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feature-requests #1444#539

Merged
nijel merged 2 commits intophpmyadmin:masterphpmyadmin/phpmyadmin:masterfrom
fustundag:masterfustundag/phpmyadmin:masterCopy head branch name to clipboard
Aug 2, 2013
Merged

feature-requests #1444#539
nijel merged 2 commits intophpmyadmin:masterphpmyadmin/phpmyadmin:masterfrom
fustundag:masterfustundag/phpmyadmin:masterCopy head branch name to clipboard

Conversation

@fustundag
Copy link
Contributor

"verbose" field check added to "lookup server"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is reason for calculating md5 from those strings?

@fustundag
Copy link
Contributor Author

When verbose contains chars required url-encode e.g. &, #, md5 option may be handy.
For example, we have verbose values at our pma config :
STK SERVER #1 ( 172.21.33.44 )
STK SERVER #2 ( 172.21.33.45 )

@fustundag fustundag closed this Jul 25, 2013
@fustundag fustundag reopened this Jul 25, 2013
@nijel
Copy link
Contributor

nijel commented Jul 25, 2013

But you're comparing md5 of verbose name against md5 of string in response, so this has same effect as line above...

@fustundag
Copy link
Contributor Author

my bad. I fixed it. You can check it.

nijel added a commit that referenced this pull request Aug 2, 2013
@nijel nijel merged commit 9816ac0 into phpmyadmin:master Aug 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.