phpdude
diff --git a/‎macrosurl/__init__.py
Copy file name to clipboardExpand all lines: macrosurl/__init__.py
+2-2Lines changed: 2 additions & 2 deletions b/‎macrosurl/__init__.py
Copy file name to clipboardExpand all lines: macrosurl/__init__.py
+2-2Lines changed: 2 additions & 2 deletions
diff --git a/‎tests/urls.py
Copy file name to clipboardExpand all lines: tests/urls.py
+9-2Lines changed: 9 additions & 2 deletions b/‎tests/urls.py
Copy file name to clipboardExpand all lines: tests/urls.py
+9-2Lines changed: 9 additions & 2 deletions
@@ -10,7 +10,7 @@
     'month': r'(0?([1-9])|10|11|12)',
     'day': r'((0|1|2)?([1-9])|[1-3]0|31)',
     'date': r'\d{4}-(0?([1-9])|10|11|12)-((0|1|2)?([1-9])|[1-3]0|31)',
-    'uuid': r'[a-fA-F0-9]{8}-?[a-fA-F0-9]{4}-?[a-fA-F0-9]{4}-?[a-fA-F0-9]{4}-?[a-fA-F0-9]{12}'
+    'uuid': r'[a-fA-F0-9]{8}-?[a-fA-F0-9]{4}-?[1345][a-fA-F0-9]{3}-?[a-fA-F0-9]{4}-?[a-fA-F0-9]{12}',
 }
 
 
@@ -74,4 +74,4 @@ def url(regex, view, kwargs=None, name=None, prefix=''):
     if isinstance(view, tuple) and len(view) == 3:
         end_dollar = False
 
-    return baseurl(MacroUrlPattern(regex, end_dollar=end_dollar), view, kwargs=kwargs, name=name, prefix=prefix)
+    return baseurl(MacroUrlPattern(regex, end_dollar=end_dollar), view, kwargs=kwargs, name=name, prefix=prefix)
@@ -66,11 +66,11 @@ def test_date(self):
 
     def test_uid(self):
         self.assertEqual(MacroUrlPattern('invoice/:uuid').compiled,
-                         '^invoice/(?P<uuid>[a-fA-F0-9]{8}-?[a-fA-F0-9]{4}-?[a-fA-F0-9]{4}-?[a-fA-F0-9]{4}-?[a-fA-F0-9]{12})$')
+                         '^invoice/(?P<uuid>[a-fA-F0-9]{8}-?[a-fA-F0-9]{4}-?[1345][a-fA-F0-9]{3}-?[a-fA-F0-9]{4}-?[a-fA-F0-9]{12})$')
 
     def test_strongurl(self):
         self.assertEqual(MacroUrlPattern('orders/:date/:uuid/products/:slug/:variant_id').compiled,
-                         '^orders/(?P<date>\\d{4}-(0?([1-9])|10|11|12)-((0|1|2)?([1-9])|[1-3]0|31))/(?P<uuid>[a-fA-F0-9]{8}-?[a-fA-F0-9]{4}-?[a-fA-F0-9]{4}-?[a-fA-F0-9]{4}-?[a-fA-F0-9]{12})/products/(?P<slug>[\\w-]+)/(?P<variant_id>\\d+)$')
+                         '^orders/(?P<date>\\d{4}-(0?([1-9])|10|11|12)-((0|1|2)?([1-9])|[1-3]0|31))/(?P<uuid>[a-fA-F0-9]{8}-?[a-fA-F0-9]{4}-?[1345][a-fA-F0-9]{3}-?[a-fA-F0-9]{4}-?[a-fA-F0-9]{12})/products/(?P<slug>[\\w-]+)/(?P<variant_id>\\d+)$')
 
     # noinspection PyProtectedMember
     def test_includes_end(self):
@@ -130,3 +130,10 @@ def test_uuid(self):
         self.assertIsNone(url("invoice/:uuid", 'view').resolve('invoice/123123-123123-1231231-1231312-3-1312312-'))
         for i in range(1, 1000):
             self.assertIsNotNone(url("invoice/:uuid", 'view').resolve('invoice/%s' % uuid.uuid4()))
+
+    def test_no_match_for_invalid_uuid(self):
+        """
+        UUID with invalid version.  The allowed versions are 1, 2, 4 and 5
+        xxxxxxxx-xxxx-Vxxx-xxx-xxxxxxxxxxxx
+        """
+        self.assertIsNone(url("invoice/:uuid", 'view').resolve('invoice/3e41b04d-0978-9027-86c2-aa90c63ecb54'))