Use Separate Config for Each Instance of ShopifySDK #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, suprised you found those changes ;) Please keep in mind that i never wrote / updated tests nor did i test everything in the library to see if anything breaks. IIRC i knew that it could make problems with the curl config or something request related, not sure anymore. Which is why i never opened a PR as i didn't have the time to make sure that it won't affect anything else. But it solved every problem i had and so it was good enough for for that project, which still runs in production with those changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request includes the code changes by @n3o77 to change the ShopifySDK config from a single, shared static config to local for each instance.
This allows you to configure multiple Shopify store connections, all within the same PHP script.
This pull-request resolves the following issues: #61, #226