Add support for Symfony 8#1125
Add support for Symfony 8#1125dantleech merged 1 commit intophpbench:masterphpbench/phpbench:masterfrom
Conversation
| if: matrix.composer-minimum-stability | ||
| run: composer config minimum-stability ${{ matrix.composer-minimum-stability }} | ||
|
|
||
| - name: Install Symfony Flex |
There was a problem hiding this comment.
Symfony Flex allows to install a specific version of Symfony, see https://symfony.com/doc/current/bundles/best_practices.html#require-a-specific-symfony-version
There was a problem hiding this comment.
if we're setting the minimum stability to dev wouldn't it already pull in SF 8?
There was a problem hiding this comment.
Hum indeed, I can remove these steps, but it means that PHPBench tests will always run on Symfony 6.1 (lowest) or Symfony 8 (highest)
There was a problem hiding this comment.
Updated, let's run the CI? :)
|
sorry, it failed due to a failing service which I've removed, could you rebase? |
|
Sure! The PR has been rebased |
|
...although that was premature, looks like it did not install symfony 8 |
|
Hum yes, that's because of friendsofphp/php-cs-fixer dependency, I will change it to the shim version (it won't conflict with the dependencies graph) |
* Use php-cs-fixer/shim instead Follows #1125 * Use Symfony Flex to fix Symfony versions * Call Application::addCommand() if exist
This PR increase version constraints on `symfony/*` packages to allow Symfony 8, which will be released this month. **EDIT:** opened phpbench/phpbench#1125
No description provided.