[ticket/17609] Remove jumpbox#6927
Open
rubencm wants to merge 1 commit intophpbb:masterphpbb/phpbb:masterfrom
Open
[ticket/17609] Remove jumpbox#6927rubencm wants to merge 1 commit intophpbb:masterphpbb/phpbb:masterfrom
rubencm wants to merge 1 commit intophpbb:masterphpbb/phpbb:masterfrom
Conversation
Member
|
Can you also add the deprecated tag to the make_jumpbox function? |
Member
Author
Is not, is still used by mcp |
PHPBB-17609
There was a problem hiding this comment.
Pull request overview
This PR removes the jumpbox feature from regular phpBB pages while preserving its functionality in the Moderator Control Panel (MCP). The jumpbox was a navigation component that provided "return to forum/index" links and a forum dropdown selector. Since breadcrumb navigation provides the same functionality, the redundant jumpbox is being removed to simplify the interface.
Changes:
- Removed
make_jumpbox()function calls from all regular pages (viewtopic, viewforum, search, posting, memberlist, login, and help/FAQ controllers) - Removed the
load_jumpboxconfiguration option from database schema, ACP settings, and language files - Simplified the
make_jumpbox()function to only work when explicitly forced (for MCP usage) - Updated jumpbox.html template to remove "return to" navigation links while keeping the forum dropdown for MCP
- Added database migration to remove the
load_jumpboxconfiguration setting - Updated events documentation to remove the deprecated
search_results_jumpbox_beforeevent
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| phpBB/viewtopic.php | Removed make_jumpbox() call |
| phpBB/viewforum.php | Removed make_jumpbox() call |
| phpBB/search.php | Removed make_jumpbox() calls from search results and search form |
| phpBB/posting.php | Removed make_jumpbox() call |
| phpBB/memberlist.php | Removed make_jumpbox() call |
| phpBB/includes/functions.php | Removed make_jumpbox() calls from login_box() and login_forum_box() |
| phpBB/includes/functions_content.php | Simplified make_jumpbox() to only work when force_display=true, removed $config global |
| phpBB/includes/acp/acp_board.php | Removed load_jumpbox setting from ACP board configuration |
| phpBB/phpbb/members/controller/team.php | Removed make_jumpbox() call |
| phpBB/phpbb/members/controller/online.php | Removed make_jumpbox() call |
| phpBB/phpbb/help/controller/help.php | Removed make_jumpbox() call |
| phpBB/phpbb/help/controller/controller.php | Removed make_jumpbox() call |
| phpBB/phpbb/db/migration/data/v400/remove_jumpbox.php | New migration to remove load_jumpbox config setting |
| phpBB/styles/prosilver/template/viewtopic_body.html | Removed jumpbox.html include |
| phpBB/styles/prosilver/template/viewforum_body.html | Removed jumpbox.html include |
| phpBB/styles/prosilver/template/viewonline_body.html | Removed jumpbox.html include |
| phpBB/styles/prosilver/template/search_results.html | Removed jumpbox.html include and search_results_jumpbox_before event |
| phpBB/styles/prosilver/template/memberlist_view.html | Removed jumpbox.html include |
| phpBB/styles/prosilver/template/memberlist_team.html | Removed jumpbox.html include |
| phpBB/styles/prosilver/template/memberlist_body.html | Removed jumpbox.html include |
| phpBB/styles/prosilver/template/login_forum.html | Removed jumpbox.html include |
| phpBB/styles/prosilver/template/faq_body.html | Removed jumpbox.html include |
| phpBB/styles/prosilver/template/jumpbox.html | Removed "return to" navigation links, kept forum dropdown for MCP |
| phpBB/language/en/acp/board.php | Removed YES_JUMPBOX language string |
| phpBB/install/schemas/schema_data.sql | Removed load_jumpbox config entry from initial schema |
| phpBB/includes/questionnaire/questionnaire.php | Removed load_jumpbox from questionnaire data |
| phpBB/docs/events.md | Removed search_results_jumpbox_before event documentation and updated viewtopic_body_footer_before description |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPBB-17609
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-17609