[Swoole] Map cookie header correctly when returning response.#188
Open
forfin wants to merge 10 commits intophp-runtime:mainphp-runtime/runtime:mainfrom
Open
[Swoole] Map cookie header correctly when returning response.#188forfin wants to merge 10 commits intophp-runtime:mainphp-runtime/runtime:mainfrom
forfin wants to merge 10 commits intophp-runtime:mainphp-runtime/runtime:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taken from: https://github.com/symfony-swoole/swoole-bundle/blob/1c18e2ba75d7671052d1ba07104747bebcbf6bab/src/Bridge/Symfony/HttpFoundation/ResponseHeadersAndStatusProcessor.php#L20
In current implementation, When multiple cookie values are expected to set, Only 1 cookie value will be appear in actual header (chrome's dev tool) while others are drop.
Relate to: #168
Ref: https://www.php.net/manual/en/class.swoole-http-response.php