Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add Async Aws #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Add Async Aws #1046

wants to merge 7 commits into from

Conversation

jderusse
Copy link

@jderusse jderusse commented Apr 12, 2020 •
edited
Loading

This PR replaces the Official AWS Sdk by AsyncAws

The main benefit is the vendor weight (AWS sdk is more than 20Mb) and less memory footprint.
See other benefit on the documentation: https://async-aws.com/compare.html

It also simplify enqueue, by provising typehint on results, and natively handling pagination (see getSubscriptions for instance).
See the diff of this PR: Screenshot from 2020-04-12 15-45-05

this Lib is used in several well known projects:

soon

This PR is WIP because need:

This PR may be a BC Break if people inject their own AwsClient, please tell me how you suggest to deal with it?

@jderusse jderusse mentioned this pull request Apr 12, 2020
Merged
@Nyholm Nyholm mentioned this pull request Apr 12, 2020
Closed
10 tasks
@jderusse
Copy link
Author

I think that providing 2 packages will be confusing for the end user.
I suggest to deprecated the classes/methods that exposes AWS package and provide a migration path to AsyncAws and keeping Backward Compatibility.
WDYT?

@jderusse
Copy link
Author

PR refactored to keep BC and provide a migration path

@stale
Copy link

stale bot commented Jun 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 2, 2020
@Nyholm
Copy link
Contributor

Nyholm commented Jun 2, 2020

We may put this in the async-aws organization.

@stale stale bot removed the wontfix label Jun 2, 2020
@jderusse jderusse changed the title WIP: Async aws Add Async Aws Jun 2, 2020
@stale
Copy link

stale bot commented Jul 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 2, 2020
@jderusse
Copy link
Author

jderusse commented Jul 3, 2020

hmm.. i'm not sure it worth it @Nyholm
https://github.com/php-enqueue/enqueue-dev/pulse/monthly

@jderusse jderusse closed this Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jderusse @Nyholm
Morty Proxy This is a proxified and sanitized view of the page, visit original site.