Populate object to object values instead of casting to array, fixes h…#166
Merged
corpsee merged 1 commit intoMar 15, 2018
php-censor:masterphp-censor/php-censor:masterfrom
Caffe1neAdd1ct:masterCopy head branch name to clipboard
Merged
Populate object to object values instead of casting to array, fixes h…#166corpsee merged 1 commit intophp-censor:masterphp-censor/php-censor:masterfrom Caffe1neAdd1ct:masterCopy head branch name to clipboard
corpsee merged 1 commit into
php-censor:masterphp-censor/php-censor:masterfrom
Caffe1neAdd1ct:masterCopy head branch name to clipboard
Conversation
| $build->setTag($copyFrom->getTag()); | ||
| $build->setCommitterEmail($copyFrom->getCommitterEmail()); | ||
| $build->setCommitMessage($copyFrom->getCommitMessage()); | ||
| $build->setExtra($copyFrom->getExtra()); |
Member
There was a problem hiding this comment.
Avoid using static access to class '\PHPCensor\BuildFactory' in method 'createDuplicateBuild'.
Contributor
Author
There was a problem hiding this comment.
Leaving as not affecting functionality and not part of this fix.
Member
|
@Caffe1neAdd1ct Thank you! Merged. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#164
Contribution type
*Bug fix
Description of change
Clicking rebuild now caused exception due to integer value not correctly cast when copying over build details to new build record (due to extracting details to array first causing string conversion).