CI fixes, Predis update, deprecation warning fix#272
Open
sideshowcoder wants to merge 5 commits intophp-cache:masterphp-cache/cache:masterfrom
Open
CI fixes, Predis update, deprecation warning fix#272sideshowcoder wants to merge 5 commits intophp-cache:masterphp-cache/cache:masterfrom
sideshowcoder wants to merge 5 commits intophp-cache:masterphp-cache/cache:masterfrom
Conversation
Author
|
Seems like there is an issue with the CI the redis container does not get pulled correctly. |
`unserialize(null)` causes a deprecation warning flooding the logs, so in case
the cache for a given cache is empty this warning will be seen. To avoid this
use `''` as a replacement.
`unserialize(null) === unserialzie('') === false` this does not change behaviour.
Predis `^2.0` has been released some time ago, this version constraint allows applications depending on `predis-adapter` to update to `predis/predis:^2.0`.
- Include predis update - Include unserialize deprecation warning
- Update redis to a supported version - Update redis-cluser to a supported version, use 6.2.10 as 7.x fails non local connections see Grokzen/docker-redis-cluster#155 - Set redis-cluster IP to 0.0.0.0 interface to allow all connections
- requires php version >= 8.0 - apply normalize fixes
f325d9b to
bc6f961
Compare
Author
|
@Nyholm would be awesome if you have a min to take a look, all the CI is passing again, which had been broken for a bit now, and a small upate to dependencies to allow good |
|
+1 on this, it would be great if this was fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
predis/predisdependency to^2.0unserialize(null)deprecation warning