Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update PSR libraries#264

Open
enumag wants to merge 1 commit intophp-cache:masterphp-cache/cache:masterfrom
enumag:update-psrenumag/cache-2:update-psrCopy head branch name to clipboard
Open

Update PSR libraries#264
enumag wants to merge 1 commit intophp-cache:masterphp-cache/cache:masterfrom
enumag:update-psrenumag/cache-2:update-psrCopy head branch name to clipboard

Conversation

@enumag
Copy link

@enumag enumag commented Jan 27, 2022

Question Answer
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? waiting for CI...
Fixed tickets
License MIT
Doc PR

Description

TODO

  • Add tests
  • Add documentation
  • Updated Changelog.md

@tm1000
Copy link

tm1000 commented Feb 11, 2022

This is required to use these libraries and update to anything that's not ancient. The PSR upgrades merely support typing and have requirements for PHP 8.x and such meaning if a system can't install them then it can just fallback to the older versions of the PSRs.

@TiiFuchs
Copy link

Just want to give this a small bump, since I currently can't use the package without those version bumps and it seems like a relatively easy fix.

@dimitri-koenig
Copy link

Hi @cryptiklemur, @Nyholm, @rvanlaak

I very kindly ask you to quickly review this easy PR and merge it. The only difference in psr/cache v2 vs v3 is added return types to interfaces, that's it.

Allowing psr/cache v3 would allow usage of this package in many other applications alongside other packages which already rely on psr/cache v3.

Merging this PR would automatically resolve many other PRs addressing the same issue (#278, #276, #268), but this particular PR imho should fix them all.

Thx in advance for your timely consideration.

Best
Dimitri

@Nyholm
Copy link
Member

Nyholm commented Jul 7, 2025

But we do implement those interfaces. I dont think merging this PR will cut it. Especially not when CI fails to run.

@dimitri-koenig
Copy link

Is there another solution to make it work with psr/cache v3?

@rvanlaak
Copy link
Member

rvanlaak commented Jul 7, 2025

Maybe add all supported PHP versions to the CI matrix first (e.g. #279)? Don't have permissions to approve running those builds.

dimitri-koenig added a commit to dimitri-koenig/php-cache that referenced this pull request Jul 7, 2025
dimitri-koenig added a commit to dimitri-koenig/php-cache that referenced this pull request Jul 7, 2025
@dimitri-koenig
Copy link

I don't see anyway to make this work if PHP 7.4 is still the minimum version. It should be raised to 8.0. Then the integration-test package should be adapted as well, and it would work.

Imho dropping 7.4 support is long overdue.

Here are my latest attempts: https://github.com/dimitri-koenig/php-cache/actions

@rvanlaak
Copy link
Member

rvanlaak commented Jul 8, 2025

1.0.0 release was of 2017, so time for a 2.0.0 release if you ask me.

@xvilo xvilo mentioned this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.