Update PSR libraries#264
Update PSR libraries#264enumag wants to merge 1 commit intophp-cache:masterphp-cache/cache:masterfrom
Conversation
|
This is required to use these libraries and update to anything that's not ancient. The PSR upgrades merely support typing and have requirements for PHP 8.x and such meaning if a system can't install them then it can just fallback to the older versions of the PSRs. |
|
Just want to give this a small bump, since I currently can't use the package without those version bumps and it seems like a relatively easy fix. |
|
Hi @cryptiklemur, @Nyholm, @rvanlaak I very kindly ask you to quickly review this easy PR and merge it. The only difference in psr/cache v2 vs v3 is added return types to interfaces, that's it. Allowing psr/cache v3 would allow usage of this package in many other applications alongside other packages which already rely on psr/cache v3. Merging this PR would automatically resolve many other PRs addressing the same issue (#278, #276, #268), but this particular PR imho should fix them all. Thx in advance for your timely consideration. Best |
|
But we do implement those interfaces. I dont think merging this PR will cut it. Especially not when CI fails to run. |
|
Is there another solution to make it work with psr/cache v3? |
|
Maybe add all supported PHP versions to the CI matrix first (e.g. #279)? Don't have permissions to approve running those builds. |
|
I don't see anyway to make this work if PHP 7.4 is still the minimum version. It should be raised to 8.0. Then the integration-test package should be adapted as well, and it would work. Imho dropping 7.4 support is long overdue. Here are my latest attempts: https://github.com/dimitri-koenig/php-cache/actions |
|
1.0.0 release was of 2017, so time for a 2.0.0 release if you ask me. |
Description
TODO