key.py functions return "false" (lowercase)#78
Closed
wizardofozzie wants to merge 2 commits intopetertodd:masterpetertodd/python-bitcoinlib:masterfrom
Closed
key.py functions return "false" (lowercase)#78wizardofozzie wants to merge 2 commits intopetertodd:masterpetertodd/python-bitcoinlib:masterfrom
wizardofozzie wants to merge 2 commits intopetertodd:masterpetertodd/python-bitcoinlib:masterfrom
Conversation
added 2 commits
August 19, 2015 18:53
Fixed Verify: lowercase "false" needs capitalisation
Fixed 2x "return false"
Owner
|
Hahaha, oh man, that's a dumb mistake. Can you add a unittest that catches this case though? |
Author
|
@petertodd I'll look through my iPython logs, because I managed to raise this Exception recently, I don't remember how off the top of my head |
Owner
|
Any luck? |
Author
|
@petertodd Yes, I found the logs. I'll link the gist ASAP as I'm currently using iOS |
Owner
|
@simcity4242 Thanks! |
Owner
|
BTW, #79 fixed this as well, but if you could add the unit tests still that'd be awesome. |
Author
|
@petertodd Apologies; lost my laptop in a theft and I've been working off iOS pythonista 1.6 (which is 2.7 based) so anything in terms of testing has been really tough for 3.x apps like this |
Owner
|
@wizardofozzie Ouch! That sucks. :( No rush, just a "would be nice" thing. Thanks for the help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Verify: lowercase "false" needs capitalisation