From f19d812ed92433d7d8e32f86966d1b7433bfbc3d Mon Sep 17 00:00:00 2001 From: Santiago San Martin Date: Fri, 20 Jun 2025 18:00:07 -0300 Subject: [PATCH 01/10] Fix yaml and xml example syntax error at factories.rst --- service_container/factories.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/service_container/factories.rst b/service_container/factories.rst index abff3f65a3d..a2643eb6440 100644 --- a/service_container/factories.rst +++ b/service_container/factories.rst @@ -397,7 +397,7 @@ e.g. change the service based on a parameter: # you can use the arg() function to retrieve an argument from the definition App\Email\NewsletterManagerInterface: - factory: "@=arg(0).createNewsletterManager() ?: service("default_newsletter_manager")" + factory: '@=arg(0).createNewsletterManager() ?: service("default_newsletter_manager")' arguments: - '@App\Email\NewsletterManagerFactory' @@ -418,7 +418,7 @@ e.g. change the service based on a parameter: - + From 80a809c94e8241cd807b0d4896b5c8812a29cb04 Mon Sep 17 00:00:00 2001 From: Santiago San Martin Date: Sun, 22 Jun 2025 13:47:54 -0300 Subject: [PATCH 02/10] fix: minor in file `webhook.rst` --- webhook.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webhook.rst b/webhook.rst index 773df3643bc..be4ccbcf95d 100644 --- a/webhook.rst +++ b/webhook.rst @@ -100,7 +100,7 @@ webhook consumer code. The webhook routing name is part of the URL you need to configure at the third-party mailer provider. The URL is the concatenation of your domain name and the routing name you chose in the configuration (like -``https://example.com/webhook/mailer_mailgun``. +``https://example.com/webhook/mailer_mailgun``). For Mailgun, you will get a secret for the webhook. Store this secret as MAILER_MAILGUN_SECRET (in the :doc:`secrets management system From 451ca516c39f137594f7412ac3224d13c5bfd88a Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Sun, 22 Jun 2025 23:29:04 +0200 Subject: [PATCH 03/10] fix code block indentation --- reference/configuration/doctrine.rst | 56 ++++++++++++++-------------- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/reference/configuration/doctrine.rst b/reference/configuration/doctrine.rst index 958e63b37f6..9fc9a0b16a8 100644 --- a/reference/configuration/doctrine.rst +++ b/reference/configuration/doctrine.rst @@ -159,22 +159,22 @@ If you want to configure multiple connections in YAML, put them under the .. code-block:: yaml - doctrine: - dbal: - default_connection: default - connections: - default: - dbname: Symfony - user: root - password: null - host: localhost - server_version: '8.0.37' - customer: - dbname: customer - user: root - password: null - host: localhost - server_version: '8.2.0' + doctrine: + dbal: + default_connection: default + connections: + default: + dbname: Symfony + user: root + password: null + host: localhost + server_version: '8.0.37' + customer: + dbname: customer + user: root + password: null + host: localhost + server_version: '8.2.0' .. code-block:: php @@ -231,18 +231,18 @@ that the ORM resolves to: .. code-block:: yaml - doctrine: - orm: - auto_mapping: false - # the standard distribution overrides this to be true in debug, false otherwise - auto_generate_proxy_classes: false - proxy_namespace: Proxies - proxy_dir: '%kernel.cache_dir%/doctrine/orm/Proxies' - default_entity_manager: default - metadata_cache_driver: array - query_cache_driver: array - result_cache_driver: array - naming_strategy: doctrine.orm.naming_strategy.default + doctrine: + orm: + auto_mapping: false + # the standard distribution overrides this to be true in debug, false otherwise + auto_generate_proxy_classes: false + proxy_namespace: Proxies + proxy_dir: '%kernel.cache_dir%/doctrine/orm/Proxies' + default_entity_manager: default + metadata_cache_driver: array + query_cache_driver: array + result_cache_driver: array + naming_strategy: doctrine.orm.naming_strategy.default .. code-block:: php From 27f0a58c91b3f3fc74be9ac99bae618305fe34f7 Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Sun, 22 Jun 2025 23:52:12 +0200 Subject: [PATCH 04/10] fix method role syntax --- messenger.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/messenger.rst b/messenger.rst index 46ee188d68d..18fc5e03cec 100644 --- a/messenger.rst +++ b/messenger.rst @@ -2356,7 +2356,7 @@ will take care of creating a new process with the parameters you passed:: } If you want to use shell features such as redirections or pipes, use the static -factory :method:Symfony\\Component\\Process\\Messenger\\RunProcessMessage::fromShellCommandline:: +:method:`Symfony\\Component\\Process\\Messenger\\RunProcessMessage::fromShellCommandline` factory method:: use Symfony\Component\Messenger\MessageBusInterface; use Symfony\Component\Process\Messenger\RunProcessMessage; From 5a55a888542ceae308025364767f6f0c30465b0e Mon Sep 17 00:00:00 2001 From: Oskar Stark Date: Mon, 23 Jun 2025 09:13:19 +0200 Subject: [PATCH 05/10] Use DOCtor-RST 1.70.0 --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 3722546330d..42770d55fe3 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -72,7 +72,7 @@ jobs: key: ${{ runner.os }}-doctor-rst-${{ steps.extract_base_branch.outputs.branch }} - name: "Run DOCtor-RST" - uses: docker://oskarstark/doctor-rst:1.69.1 + uses: docker://oskarstark/doctor-rst:1.70.0 with: args: --short --error-format=github --cache-file=/github/workspace/.cache/doctor-rst.cache From 7900a2aa4e0405c294833f71f693b392238a8c73 Mon Sep 17 00:00:00 2001 From: Jordi Boggiano Date: Mon, 23 Jun 2025 13:49:59 +0200 Subject: [PATCH 06/10] Add note about concurrency limits --- http_client.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/http_client.rst b/http_client.rst index 15a3a9ef8a8..3904368d50f 100644 --- a/http_client.rst +++ b/http_client.rst @@ -1355,6 +1355,10 @@ code waits only when necessary. or access to certificate files). To avoid hitting these limits, consider processing requests in batches. + There is however a maximum amount of concurrent connections that can be open + per host (6 by default). See + :doc:`max_host_connections `. + Multiplexing Responses ~~~~~~~~~~~~~~~~~~~~~~ From 90be650dd8be29d435306bb80133d3db54e68bf8 Mon Sep 17 00:00:00 2001 From: Thomas Landauer Date: Mon, 23 Jun 2025 17:42:25 +0200 Subject: [PATCH 07/10] [Templates] Removing self-closing slashes Page: https://symfony.com/doc/current/templates.html --- templates.rst | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/templates.rst b/templates.rst index 151ac5f71be..e895b4a6df3 100644 --- a/templates.rst +++ b/templates.rst @@ -304,10 +304,10 @@ You can now use the ``asset()`` function: .. code-block:: html+twig {# the image lives at "public/images/logo.png" #} - Symfony! + Symfony! {# the CSS file lives at "public/css/blog.css" #} - + {# the JS file lives at "public/bundles/acme/js/loader.js" #} @@ -332,7 +332,7 @@ as follows: .. code-block:: html+twig - Symfony! + Symfony! @@ -973,7 +973,7 @@ following code to display the user information is repeated in several places: {# ... #} @@ -1258,7 +1258,7 @@ In practice, the ``base.html.twig`` template would look like this: {% block title %}My Application{% endblock %} {% block stylesheets %} - + {% endblock %} From 01915d0a3448db4b8ba415abe35793498a51f43f Mon Sep 17 00:00:00 2001 From: Javier Eguiluz Date: Tue, 24 Jun 2025 09:19:05 +0200 Subject: [PATCH 08/10] [Templating] [Templates] Removing self-closing slashes --- templates.rst | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/templates.rst b/templates.rst index 0041077dfed..bc249024f05 100644 --- a/templates.rst +++ b/templates.rst @@ -304,10 +304,10 @@ You can now use the ``asset()`` function: .. code-block:: html+twig {# the image lives at "public/images/logo.png" #} - Symfony! + Symfony! {# the CSS file lives at "public/css/blog.css" #} - + {# the JS file lives at "public/bundles/acme/js/loader.js" #} @@ -332,7 +332,7 @@ as follows: .. code-block:: html+twig - Symfony! + Symfony! @@ -946,7 +946,7 @@ following code to display the user information is repeated in several places: {# ... #} @@ -1231,7 +1231,7 @@ In practice, the ``base.html.twig`` template would look like this: {% block title %}My Application{% endblock %} {% block stylesheets %} - + {% endblock %} From 9ad93fa3eda5d3786b50d98f965315c18412ba0a Mon Sep 17 00:00:00 2001 From: Javier Eguiluz Date: Tue, 24 Jun 2025 09:29:00 +0200 Subject: [PATCH 09/10] Fix some RST issues --- http_client.rst | 10 +++++----- reference/configuration/framework.rst | 2 ++ 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/http_client.rst b/http_client.rst index 3904368d50f..36ed66a1506 100644 --- a/http_client.rst +++ b/http_client.rst @@ -167,8 +167,9 @@ Some options are described in this guide: Check out the full :ref:`http_client config reference ` to learn about all the options. -The HTTP client also has one configuration option called -``max_host_connections``, this option can not be overridden by a request: +The HTTP client also has a configuration option called +:ref:`max_host_connections `. +This option cannot be overridden per request: .. configuration-block:: @@ -1355,9 +1356,8 @@ code waits only when necessary. or access to certificate files). To avoid hitting these limits, consider processing requests in batches. - There is however a maximum amount of concurrent connections that can be open - per host (6 by default). See - :doc:`max_host_connections `. + There is, however, a maximum amount of concurrent connections that can be open + per host (``6`` by default). See :ref:`max_host_connections `. Multiplexing Responses ~~~~~~~~~~~~~~~~~~~~~~ diff --git a/reference/configuration/framework.rst b/reference/configuration/framework.rst index 6376c057940..d97c59dd9e9 100644 --- a/reference/configuration/framework.rst +++ b/reference/configuration/framework.rst @@ -1129,6 +1129,8 @@ max_duration The maximum execution time, in seconds, that the request and the response are allowed to take. A value lower than or equal to 0 means it is unlimited. +.. _reference-http-client-max-host-connections: + max_host_connections .................... From e56a427ab53d52fbb0ee1b96554648a540855219 Mon Sep 17 00:00:00 2001 From: Pieter Oliver Date: Tue, 24 Jun 2025 12:22:57 +0100 Subject: [PATCH 10/10] Fix typo --- reference/constraints/Url.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reference/constraints/Url.rst b/reference/constraints/Url.rst index 74f0d750dfd..1e9bb8ac62e 100644 --- a/reference/constraints/Url.rst +++ b/reference/constraints/Url.rst @@ -323,7 +323,7 @@ also relative URLs that contain no protocol (e.g. ``//example.com``). and will default to ``true`` in Symfony 8.0. By default, URLs like ``https://aaa`` or ``https://foobar`` are considered valid -because they are tecnically correct according to the `URL spec`_. If you set this option +because they are technically correct according to the `URL spec`_. If you set this option to ``true``, the host part of the URL will have to include a TLD (top-level domain name): e.g. ``https://example.com`` will be valid but ``https://example`` won't.