Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

roekatz
Copy link
Contributor

@roekatz roekatz commented Apr 24, 2024

Fix race condition in broadcaster disconnection test by closing Websocket connection after disconnection.
Fix multiprocess test by switching from asyncio.get_event_loop().run_until_complete to asyncio.run (which is higher level, more stable and recommended to use)

@roekatz roekatz requested review from asafc and orweis April 24, 2024 09:38
@roekatz roekatz force-pushed the rk/fix-broadcaster-disconnection-test branch from efe3bb9 to 86c5ff2 Compare April 24, 2024 11:04
@roekatz roekatz force-pushed the rk/fix-broadcaster-disconnection-test branch from 8f203b9 to 00ebbb7 Compare April 24, 2024 11:25
@roekatz roekatz changed the title Tests: Fix broadcaster disconnection test race condition Fix failing tests - broadcaster disconnection & multiprocess Apr 24, 2024
@roekatz roekatz merged commit 70fdaae into master Apr 24, 2024
@roekatz roekatz deleted the rk/fix-broadcaster-disconnection-test branch April 24, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.