Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Dec 12, 2023

What: Closes #9882 Towards #9880, #9878, #9850

Changes to Avatar:

Expandable Section

  • Removed isActive prop

Pagination

  • removed pf-m-compact modifier

@tlabaj tlabaj changed the base branch from nicolethoen-patch-1 to v6 December 12, 2023 17:21
@patternfly-build
Copy link
Contributor

patternfly-build commented Dec 12, 2023

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one change below

@tlabaj tlabaj requested a review from thatblindgeye December 13, 2023 19:39
onLastClick={onLastClick}
onPageInput={onPageInput}
isDisabled={isDisabled}
isCompact={isCompact}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to add this back as well so it can be passed to the Navigation

@tlabaj tlabaj requested a review from thatblindgeye December 13, 2023 20:40
@wise-king-sullyman wise-king-sullyman merged commit b58518f into patternfly:v6 Dec 13, 2023
@tlabaj tlabaj mentioned this pull request Dec 13, 2023
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-charts@8.0.0-alpha.4
  • @patternfly/react-code-editor@6.0.0-alpha.5
  • @patternfly/react-core@6.0.0-alpha.5
  • @patternfly/react-docs@7.0.0-alpha.5
  • @patternfly/react-icons@6.0.0-alpha.4
  • demo-app-ts@5.1.1-alpha.4
  • @patternfly/react-styles@6.0.0-alpha.4
  • @patternfly/react-table@6.0.0-alpha.5
  • @patternfly/react-tokens@6.0.0-alpha.4

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.