feat(NotificationBadge): refactor to use status buttons for penta #10020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-10020.surge.sh A11y report: https://patternfly-react-pr-10020-a11y.surge.sh |
nicolethoen
reviewed
Jan 18, 2024
|
@nicolethoen I think that might be more of a bug with button, but there are some ways we could resolve it NotificationBadge side. I could pass the icon as a child of the Button when there isn't a count, and to the I wonder if we should cut the flexibility of NotificationBadge back in penta since if a more custom solution is needed consumers can just customize the stateful Button themselves 🤔 |
nicolethoen
approved these changes
Jan 30, 2024
thatblindgeye
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9811
Additional issues:
Core is removing the notification badge, this PR internally replaces our notification badge with the button component while keeping the external API the same.
Convenience link: https://patternfly-react-pr-10020.surge.sh/components/notification-badge