fix(core): remove @floating-ui/dom dependency
#2945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@floatingui/dom dependency
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "fix(core): remove `@floating-ui/dom` dependency"
} |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@floatingui/dom dependency@floating-ui/dom dependency
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR is an attempt to static the implementation of
@floating-ui/dom, so we no longer have to update that dependency or serve it downstream. This implementation will eventually be replaced entirely with browser APIs in anchor positioning.@floating-ui/domdependency by way of AI copying its functionality into our own repo.pfe-core/core/functions.FloatingDomControllerto import from the new location.TODO
Testing Instructions
Notes to Reviewers
The copied API was completed with the assistance of Claude AI. Please give extra scrutiny to this code.