Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix(core): prevent race condition on programmatic scroll #2911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
Loading
from
Open

fix(core): prevent race condition on programmatic scroll #2911

wants to merge 1 commit into from

Conversation

brianferry
Copy link
Collaborator

@brianferry brianferry commented Jun 11, 2025 •
edited
Loading

What I did

ScrollSpyController

  1. Added a destinationTarget property for when an activeLink is set.
  2. When the destinationTarget comes into view, it sets the #force flag to false and clears the destinationTarget.

There is a race condition that is causing this issue RedHat-UX/red-hat-design-system#2425 where the rh-jump-link component gets out of sync during a programmatic scroll event.

What we're doing here is instead looking to see if we've arrived at the destinationTarget and that the destinationTarget is intersected before we continue on with the onIo action.

Testing Instructions

This is a fix that will be felt upstream in RHDS

  1. Build the project
  2. Link the project or overwrite your scroll-spy-controller.js files in rhds-elements
  3. Confirm that [bug] <rh-jump-links> Active state not consistent RedHat-UX/red-hat-design-system#2425 is not an issue for you anymore.

Notes to Reviewers

@netlify Netlify
Copy link

netlify bot commented Jun 11, 2025 •
edited by github-actions bot
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit cdbc788
😎 Deploy Preview https://deploy-preview-2911--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 11, 2025 •
edited
Loading

✅ Commitlint tests passed!

More Info 
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "fix(core): prevent race condition on programmatic scroll"
}

@github-actions github-actions bot added the AT passed Automated testing has passed label Jun 11, 2025
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@brianferry brianferry marked this pull request as ready for review June 13, 2025 13:14
@brianferry brianferry mentioned this pull request Jun 13, 2025
Open
@bennypowers
Copy link
Member

see also #2920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

AT passed Automated testing has passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brianferry @bennypowers
Morty Proxy This is a proxified and sanitized view of the page, visit original site.