fix(CodeModal): Adjust PF code editor header border#694
Merged
nicolethoen merged 1 commit intopatternfly:mainpatternfly/chatbot:mainfrom Oct 1, 2025
rebeccaalpert:codemodal-headerrebeccaalpert/virtual-assistant:codemodal-headerCopy head branch name to clipboard
Merged
fix(CodeModal): Adjust PF code editor header border#694nicolethoen merged 1 commit intopatternfly:mainpatternfly/chatbot:mainfrom rebeccaalpert:codemodal-headerrebeccaalpert/virtual-assistant:codemodal-headerCopy head branch name to clipboard
nicolethoen merged 1 commit intopatternfly:mainpatternfly/chatbot:mainfrom
rebeccaalpert:codemodal-headerrebeccaalpert/virtual-assistant:codemodal-headerCopy head branch name to clipboard
Conversation
|
Preview: https://chatbot-pr-chatbot-694.surge.sh A11y report: https://chatbot-pr-chatbot-694-a11y.surge.sh |
PatternFly looks like it changed the way the border is applied in pre-release version. The spacing of the tabs were also changed. Adjusting our styles to account for change.
8cafbf3 to
29f07a9
Compare
thatblindgeye
approved these changes
Oct 1, 2025
nicolethoen
approved these changes
Oct 1, 2025
|
🎉 This PR is included in version 6.4.0-prerelease.26 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PatternFly looks like it changed the way the border is applied in pre-release version. The spacing of the tabs were also changed. Adjusting our styles to account for change.
It's hard to show the impact here because of the circular dependencies with the docs framework - I made these changes manually looking at https://staging.patternfly.org/patternfly-ai/chatbot/messages/#editable-attachments. They are non-breaking on Surge with the old React versions: https://chatbot-pr-chatbot-694.surge.sh/patternfly-ai/chatbot/messages#editable-attachments.
I'm not concerned about the code text color change - we were pulling defaults from PF for that and it was changed in React/Core.