Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

GH128 Multiple removal of old stubs, unimplement methods using stubtest #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2025
Merged

GH128 Multiple removal of old stubs, unimplement methods using stubtest #1218

merged 2 commits into from
May 18, 2025

Conversation

loicdiridollou
Copy link
Member

@loicdiridollou
Copy link
Member Author

I ran poetry run poe stubtest and clean up some of the items: mostly arguments defaults misspecified, functions/attribute/property that do not exist anymore.

loicdiridollou
loicdiridollou commented May 17, 2025
View reviewed changes
pandas-stubs/io/formats/style.pyi Show resolved Hide resolved
loicdiridollou
loicdiridollou commented May 17, 2025
View reviewed changes
pandas-stubs/io/sql.pyi Show resolved Hide resolved
loicdiridollou
loicdiridollou commented May 17, 2025
View reviewed changes
pandas-stubs/tseries/frequencies.pyi Show resolved Hide resolved
loicdiridollou
loicdiridollou commented May 17, 2025
View reviewed changes
pandas-stubs/util/_tester.pyi Outdated Show resolved Hide resolved
loicdiridollou
loicdiridollou commented May 17, 2025
View reviewed changes
pandas-stubs/util/_validators.pyi Show resolved Hide resolved
Dr-Irv
Dr-Irv requested changes May 18, 2025
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this. It picked up some good things and things we ought to change.

pandas-stubs/io/sql.pyi Show resolved Hide resolved
pandas-stubs/io/sql.pyi Outdated Show resolved Hide resolved
pandas-stubs/tseries/frequencies.pyi Show resolved Hide resolved
pandas-stubs/io/formats/style.pyi Show resolved Hide resolved
pandas-stubs/util/_tester.pyi Outdated Show resolved Hide resolved
pandas-stubs/util/_validators.pyi Show resolved Hide resolved
Dr-Irv
Dr-Irv approved these changes May 18, 2025
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @loicdiridollou

@Dr-Irv Dr-Irv merged commit 8607315 into pandas-dev:main May 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLEAN: Reconcile types in pandas._typing.py and pandas-stubs._typing.pyi
2 participants
@loicdiridollou @Dr-Irv
Morty Proxy This is a proxified and sanitized view of the page, visit original site.