-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Subplot title count fix + fix for issue introduced in earlier PR #61393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
8440dde
test case for subplot stacking
eicchen 350a7ec
Removed overlooked print statement
eicchen b27d1ac
Updated test to check other subplot in figure
eicchen 46c6eaa
Merge commit '5736b9647068d31fdf8673d3528cb64e35060bac' into bar_plot…
eicchen 1fe342a
Updated test cases to include more subplot stacking possibilities
eicchen de55789
removed savefig() left in test cases
eicchen e8a6f91
Updated test cases to test more arrangements
eicchen 0d9f5da
Completed function fix (order of subplot input does not matter, need …
eicchen b356028
appeasing the great pre-commit formatter
eicchen 6cd8a51
Merge branch 'main' into bar_plot_stacking_fix
eicchen 4cc2905
Updated whatsnew
eicchen 9974632
Docstring adjustment
eicchen ddd3311
Moved self.subplot check to a seperate bool
eicchen df51168
Added ignore where mypy thinks self.subplots is a bool
eicchen bfb1dd1
Actually addressed mypy typing
eicchen e4d5040
Incorperated initial PR comments
eicchen 101ee62
Updated missing () after .all
eicchen cfa3ada
Initial test cases
eicchen 2a8f126
Addressed more comments on PR
eicchen 9630ee5
Updated '&' to 'and'
eicchen ab4f7a6
Updated Test cases
eicchen abe5c3f
Fixed crash when "subplots=True" is used
eicchen 2e8fc9a
Title check checks for subplot length if specified
eicchen 9dd73d1
Updated Test cases
eicchen 7e50fa0
Title check checks for subplot length if specified
eicchen 0273814
Merge branch 'subplot_label_count_fix' of https://github.com/eicchen0…
eicchen d501e49
Updated test name
eicchen 584a4a9
Removed extra '_' in test name
eicchen 16b6792
Fixed issue where expected_total_height returns as a df instead of a …
eicchen 67f3b41
Merge branch 'bar_plot_stacking_fix' into subplot_label_count_fix
eicchen 11c7a88
Updated change notes
eicchen c895916
Addressed mypy error
eicchen 878e610
Addresed PR comments
eicchen b93eedb
Changed exception message raised and updated test case
eicchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Title check checks for subplot length if specified
- Loading branch information
commit 2e8fc9ac2d17783b63a9a39ca8d3ee9453e330f1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.