Bug cov nat #60898
Open
Bug cov nat #60898
+80
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fbourgey
commented
Feb 9, 2025
- closes BUG: cov buggy when having NaT in column #53115
WillAyd
reviewed
Feb 14, 2025
|
@jbrockmendel, @WillAyd, could you please take a look? |
WillAyd
approved these changes
May 15, 2025
pandas/core/internals/managers.py
Outdated
| @@ -1800,6 +1800,8 @@ def as_array( | ||
| arr = np.asarray(blk.values, dtype=dtype) | ||
| else: | ||
| arr = np.array(blk.values, dtype=dtype, copy=copy) | ||
| if passed_nan and blk.dtype.kind in ["m", "M"]: |
There was a problem hiding this comment.
we usually do this check as in "mM" as it is slightly faster
pandas/core/frame.py
Outdated
| @@ -11350,6 +11352,13 @@ def cov( | ||
| c -0.150812 0.191417 0.895202 | ||
| """ | ||
| data = self._get_numeric_data() if numeric_only else self | ||
| dtypes = [blk.dtype for blk in self._mgr.blocks] | ||
| if any(is_datetime64_any_dtype(d) or is_timedelta64_dtype(d) for d in dtypes): |
There was a problem hiding this comment.
i suspect that doing the check this way (instead of checking dtype.kind like you do below) will fail to exclude pyarrow duration dtypes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.