BUG: Add fillna at the beginning of _where not to fill NA. #60729 #60772
ENH: Optimze test_mask_na()
Co-authored-by: WillAyd <will_ayd@innobi.io>
- Loading branch information
commit d2d5f62c120739a4b1c55fdb7bb3351d45d42337
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,10 @@ | ||
| import numpy as np | ||
| import pytest | ||
|
|
||
| from pandas import ( | ||
| Int64Dtype, | ||
| Series, | ||
| ) | ||
| import pandas._testing as tm | ||
|
|
||
|
|
||
|
|
@@ -71,15 +74,8 @@ def test_mask_inplace(): | |
|
|
||
| def test_mask_na(): | ||
| # We should not be filling pd.NA. See GH#60729 | ||
| series = Series([None, 1, 2, None, 3, 4, None], dtype=Int64Dtype()) | ||
| result = series.mask(series <= 2, -99) | ||
|
There was a problem hiding this comment. Can you also test the case where the condition is an ndarray and a list. There was a problem hiding this comment. Thanks @rhshadrach , add tests for a list and an ndarray. Could you review the code change? |
||
| expected = Series([None, 1, 2, None, -99, -99, None], dtype=Int64Dtype()) | ||
|
|
||
| tm.assert_series_equal(result, expected) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add a test for arrow. Can parametrize with e.g.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just added a test for pyarrow.