Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

DEPS: skip html tests if html5lib is not installed #40198 #40233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 5, 2021
Merged

DEPS: skip html tests if html5lib is not installed #40198 #40233

merged 4 commits into from
Mar 5, 2021

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Mar 4, 2021 •
edited
Loading

@fangchenli fangchenli added Dependencies Required and optional dependencies CI Continuous Integration IO HTML read_html, to_html, Styler.apply, Styler.applymap labels Mar 4, 2021
@jbrockmendel
Copy link
Member

looks like other tests are missing html5lib

lithomas1
lithomas1 reviewed Mar 4, 2021
View reviewed changes
pandas/tests/io/test_html.py Outdated Show resolved Hide resolved
lithomas1
lithomas1 reviewed Mar 4, 2021
View reviewed changes
pandas/tests/io/test_html.py Outdated Show resolved Hide resolved
@lithomas1 lithomas1 added this to the 1.2.4 milestone Mar 5, 2021
@jreback jreback merged commit 940926f into pandas-dev:master Mar 5, 2021
@jreback
Copy link
Contributor

jreback commented Mar 5, 2021

thanks @fangchenli and @lithomas1

@jreback
Copy link
Contributor

jreback commented Mar 5, 2021

@meeseeksdev backport 1.2.x

@meeseeksmachine meeseeksmachine mentioned this pull request Mar 5, 2021
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 5, 2021
@fangchenli @meeseeksmachine
Backport PR pandas-dev#40233: DEPS: skip html tests if html5lib is no…
9d43a6e 
…t installed pandas-dev#40198
simonjayhawkins pushed a commit that referenced this pull request Mar 5, 2021
@meeseeksmachine @fangchenli
Backport PR #40233: DEPS: skip html tests if html5lib is not installed …
738f3a0 
…#40198 (#40253)

Co-authored-by: Fangchen Li <fangchen.li@outlook.com>
@fangchenli fangchenli deleted the skip-bs4-test branch March 18, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lithomas1 lithomas1 lithomas1 left review comments

Assignees
No one assigned
Labels
CI Continuous Integration Dependencies Required and optional dependencies IO HTML read_html, to_html, Styler.apply, Styler.applymap
Projects
None yet
Milestone
1.2.4
Development

Successfully merging this pull request may close these issues.

DEPS: bs4 / html5lib failure
4 participants
@fangchenli @jbrockmendel @jreback @lithomas1
Morty Proxy This is a proxified and sanitized view of the page, visit original site.