Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

ENH: dt.day_of_week should return int8 #58185

Copy link
Copy link
Open
@WillAyd

Description

@WillAyd
Issue body actions

Feature Type

  • Adding new functionality to pandas

  • Changing existing functionality in pandas

  • Removing existing functionality in pandas

Problem Description

For NumPy types today this returns int32.

In [3]: pd.Series(["2024-01-01", "2024-01-02", "2024-01-03"], dtype="datetime64[us]").dt.day_of_week
Out[3]: 
0    0
1    1
2    2
dtype: int32

pyarrow dates return int64:

In [18]:   pa_arr = pa.array([
    ...:       datetime.date(2024, 1, 1),
    ...:       datetime.date(2024, 1, 2),
    ...:       datetime.date(2024, 1, 3),
    ...:   ])
    ...:   ser = pd.Series(pa_arr, dtype=pd.ArrowDtype(pa.date32()))

In [19]: ser.dt.day_of_week
Out[19]: 
0    0
1    1
2    2
dtype: int64[pyarrow]

Feature Description

Both could reasonably return int8 or even uint8 since the domain values are 0-6

Alternative Solutions

status quo

Additional Context

No response

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.