Fix completions for quoted/escaped parameters in Fish #3013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can you please rebase so that it only contains your commit. I changed the branch to stable. |
Collaborator
|
@AndreasBackx Would you mind reviewing this? |
a4161f4 to
4d48943
Compare
Contributor
Author
|
I rebased the changes |
Collaborator
|
Looks sane, I'm not super familiar with Fish itself and how it handles the |
Collaborator
|
@HansLehnert could you please make a separate PR for changes. I did not see there wasn't one. |
Collaborator
|
I'll take care of the CHANGES mention, don't worry about it as I merged this without checking. @HansLehnert |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix completions for Fish shell when the value being completed has spaces
or is enclosed in quotes
Fixes #2995