Fix edits that occur at the end of the file#91
Merged
gatesn merged 1 commit intodeveloppalantir/python-language-server:developfrom Aug 10, 2017
ngates/fix-eof-editspalantir/python-language-server:ngates/fix-eof-editsCopy head branch name to clipboard
Merged
Fix edits that occur at the end of the file#91gatesn merged 1 commit intodeveloppalantir/python-language-server:developfrom ngates/fix-eof-editspalantir/python-language-server:ngates/fix-eof-editsCopy head branch name to clipboard
gatesn merged 1 commit intodeveloppalantir/python-language-server:developfrom
ngates/fix-eof-editspalantir/python-language-server:ngates/fix-eof-editsCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had previously special-cased an empty file by creating an empty line.
But the case was more general and happens whenever edits occur at the very end of a file.
We remove the special case for empty, and instead special case end-of-file edits. This is because when we enumerate
lines, we stop enumerating 1 before the change line!