Handle windows paths in workspace.get_uri_like + test#87
Merged
gatesn merged 4 commits intopalantir:developpalantir/python-language-server:developfrom Aug 7, 2017
tomv564:fix_uri_like_windowstomv564/python-language-server:fix_uri_like_windowsCopy head branch name to clipboard
Merged
Handle windows paths in workspace.get_uri_like + test#87gatesn merged 4 commits intopalantir:developpalantir/python-language-server:developfrom tomv564:fix_uri_like_windowstomv564/python-language-server:fix_uri_like_windowsCopy head branch name to clipboard
gatesn merged 4 commits intopalantir:developpalantir/python-language-server:developfrom
tomv564:fix_uri_like_windowstomv564/python-language-server:fix_uri_like_windowsCopy head branch name to clipboard
Conversation
The assumption is that the definition points to the current file instead
gatesn
reviewed
Aug 7, 2017
Contributor
gatesn
left a comment
There was a problem hiding this comment.
Good catches here. One thing I'd say, is do we need to url quote the path we use in the uri_like function? I know it's not part of this Pr but may as well slip it in
Contributor
Author
|
Sounds like a good idea, I'll add quoting. |
gatesn
reviewed
Aug 7, 2017
pyls/workspace.py
Outdated
| unicode objects. | ||
| """ | ||
| parts = list(urlparse(doc_uri)) | ||
| if path[0] != '/': # fix path for windows |
Contributor
There was a problem hiding this comment.
Can we add and ':' in path just to make sure we don't throw on the next line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #85 where windows paths were not prefixed and converted to forward slashes