Synchronize document text updates #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
ccordoba12
reviewed
Sep 25, 2020
Contributor
ccordoba12
left a comment
There was a problem hiding this comment.
Thanks @andfoy for this! Could you mention the motivation for these changes in the PR description?
Also, is it possible to add a test for this?
ccordoba12
reviewed
Sep 26, 2020
Contributor
ccordoba12
left a comment
There was a problem hiding this comment.
@andfoy, is it possible to add a test for this?
Contributor
Author
|
It is not possible to guarantee a certain scenario for concurrent accesses, since it is not possible to ensure that a specific thread arrives before other |
ccordoba12
approved these changes
Oct 3, 2020
Contributor
ccordoba12
left a comment
There was a problem hiding this comment.
Thanks @andfoy, looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #793
Closes #798