Add signature plugin back to CORE_PLUGINS#83
Merged
gatesn merged 2 commits intopalantir:developpalantir/python-language-server:developfrom Jul 26, 2017
tomv564:enable_signature_helptomv564/python-language-server:enable_signature_helpCopy head branch name to clipboard
Merged
Add signature plugin back to CORE_PLUGINS#83gatesn merged 2 commits intopalantir:developpalantir/python-language-server:developfrom tomv564:enable_signature_helptomv564/python-language-server:enable_signature_helpCopy head branch name to clipboard
gatesn merged 2 commits intopalantir:developpalantir/python-language-server:developfrom
tomv564:enable_signature_helptomv564/python-language-server:enable_signature_helpCopy head branch name to clipboard
Conversation
gatesn
reviewed
Jul 26, 2017
pyls/plugins/__init__.py
Outdated
| completion, definition, format, | ||
| hover, pyflakes_lint, pycodestyle_lint, | ||
| references, symbols | ||
| references, symbols, signature |
Contributor
There was a problem hiding this comment.
Nit: can it be alphabetical? 😀
Contributor
Author
There was a problem hiding this comment.
Fixed, that was so close already :)
About building PRs from forks, is it a fixable problem? Circle's documentation mentioned the risk of leaking secrets?
gatesn
approved these changes
Jul 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82 where the signature help plugin was not being registered with pluggy, resulting in empty responses.