Fix #515 don't ignore LSP client's snippet support capabilities #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for your interest in palantir/python-language-server, @Shougo! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Author
|
Please test it. |
This was referenced Mar 16, 2019
|
Tested it, works fine |
|
Really looking forward to this merge |
Author
|
I have fixed unit tests. |
|
ping @palantirtech |
|
I think this pr should be merged. |
|
ping @gatesn |
Contributor
|
Apologies, I've been out on vacation. For expediency, I've made a few changes to this PR here: #529. Namely, the jedi setting for enabling snippets doesn't override what client capabilities say; and snippets are only generated for positional arguments. |
Author
|
OK. |
joaotavora
added a commit
to joaotavora/python-language-server
that referenced
this pull request
Oct 11, 2019
This is the way python-language-server used to work before palantir#519. This shouldn't conflict with the goals of palantir#515 of palantir#526, i.e. if the client does _not_ declare support for snippets, none are sent. * pyls/plugins/jedi_completion.py (pyls_completions): Default should_include_params to True, like before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #515